Color-code install preview: red for errors, yellow for warnings, green for ready#4512
Open
Softer wants to merge 3 commits intoarchlinux:masterfrom
Open
Color-code install preview: red for errors, yellow for warnings, green for ready#4512Softer wants to merge 3 commits intoarchlinux:masterfrom
Softer wants to merge 3 commits intoarchlinux:masterfrom
Conversation
…n for ready Add preview_markup opt-in field to MenuItem with automatic Rich markup escaping for all existing previews. Show missing configs and bootloader errors in red, network warning in yellow, "Ready to install" in green. Move network warning from confirmation dialog to install preview so it is visible earlier.
Contributor
Author
|
Converted into draft because looks like I found an error. Will check a bit later... |
Text.from_markup() replaces Label(markup=True) to avoid MarkupError on strings containing ["
Contributor
Author
|
Done, now it works correctly :-) |
svartkanin
reviewed
May 3, 2026
svartkanin
reviewed
May 3, 2026
Contributor
Author
|
Renamed InputInfoType to MsgLevelType, added PreviewResult dataclass, removed preview_markup from MenuItem. The widget now maps level to color instead of business logic producing Rich markup. preview_action accepts str | PreviewResult | list[PreviewResult] | None so sections with different levels can be mixed in one preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Color codes
Examples
Test plan